Rename token to assetHash for spot assets #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Comment on lines
+10
to
+11
| if (value.startsWith('0x')) { | ||
| value = value.slice(2) |
There was a problem hiding this comment.
I'm not sure if this is a better approach. We are slicing the 0x prefix if it's there and then we are adding it anyway.
There was a problem hiding this comment.
This is done to pad the length to 64. So that 0x000ab and 0xab end up being equal.
Wendrowiec13
approved these changes
Feb 13, 2023
@Wendrowiec13 good spot, fixed. |
sz-piotr
requested changes
Feb 13, 2023
sz-piotr
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves L2B-824
Up until now we have used the name
tokenand assumed it's aPedersenHashwhen dealing with spot assets (for example inVaultLeafandvaultstable). After recent refactoring we have a properAssetHashtype for spot assets. We also know it's not a Pedersen hash but a sliced Keccak.This PR renames
tokentoassetHashand the type fromPedersenHashtoAssetHash. The nametokenis preserved only in zed parsing code as this is the name that comes from DAC.