Update asset registration to merge on conflict #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed when syncing restarts from earlier block, e.g. when state update was interrupted
Wendrowiec13
approved these changes
Feb 15, 2023
sz-piotr
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When state update is halted half-way and backend is restarted, it restarts syncing from last synced block. But since some asset registrations have already gone to the DB in the previous, halted run, they cause unique constraint violation.
Even though I see merit in adding blockNumber and timestamp with proper rollback support for asset registrations, for now I opt for a quick solution of adding
onConflict().merge()and revisiting it in the future.