New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new forced actions page #270

Merged

torztomasz merged 43 commits into master from implement-new-forced-actions-page

Feb 17, 2023

Contributor

torztomasz commented Feb 16, 2023

Resolves L2B-833

torztomasz added 17 commits

February 14, 2023 23:38


          Implement forced actions page design

42ad1ea


          change navbar text color

c9ba52d


          remove unnecesary nesting

bc57b56


          remove unnecessary prop

17f0c36


          remove unnecessary nesting

928073d


          clean classnames

319184c


          fix Inter font not being used as default

070f110


          move AssetDetails to shared package

45e1d91


          implement image fallback functionality

e0c77c6


          add AssetWithLogo component

3b17835


          add more icons to assetUtils

e23da64


          add arrow icons

31d1731


          create constants file

80dd7cf


          implement new forced actions

25e8b10


          format assetUtils

3034b0c


          run lint:fix

71aa080


          Merge remote-tracking branch 'origin/master' into implement-new-force…

54a65d0

…d-actions-page

linear bot commented Feb 16, 2023

L2B-833 Implement new Forced Actions page

torztomasz added 10 commits

February 16, 2023 14:16


          resolve issues after merge

7cb4ea2


          remove restricted imports

daface2


          run format:fix

27df406


          make price input show usdc always

03365b2


          improve preview routes for forced pages

a4e0086


          run format:fix

fdf96cb


          add zod schema for AccountDetails

bf44cc4


          fix build issue

2564ffe


          run lint:fix

27c9038


          fix build issues

60e7128

Contributor

Wendrowiec13 commented Feb 16, 2023

What was the reason you put AssetDetails in the shared package instead of in the types package?

Wendrowiec13 reviewed

View reviewed changes

packages/frontend/src/preview/data.ts Show resolved Hide resolved

Wendrowiec13 reviewed

View reviewed changes

packages/frontend/src/utils/assetUtils.ts Outdated Show resolved Hide resolved

Wendrowiec13 reviewed

View reviewed changes

packages/frontend/src/utils/assetUtils.ts Outdated Show resolved Hide resolved

Wendrowiec13 reviewed

View reviewed changes

packages/frontend/src/utils/assetUtils.ts Show resolved Hide resolved

Wendrowiec13 reviewed

View reviewed changes

packages/frontend/src/view/components/common/Button.tsx Outdated Show resolved Hide resolved

Wendrowiec13 reviewed

View reviewed changes

packages/frontend/src/view/components/common/FancyList.tsx Outdated Show resolved Hide resolved

Wendrowiec13 reviewed

View reviewed changes

packages/frontend/src/view/pages/forcedactions/ForcedWithdrawPage.tsx Outdated Show resolved Hide resolved

torztomasz added 6 commits

February 17, 2023 08:58


          remove outline from inputs

73757f1


          align text in inputs

c0c8c6b


          refactor FancyList to OrderedList

b578c9d


          update forced actions page description and path

4beb442


          fix amount input balance

b30f0d2


          add dev routes for forced actions

d37d574

sz-piotr requested changes

View reviewed changes

packages/frontend/src/view/index.ts Outdated Show resolved Hide resolved

packages/frontend/src/view/pages/forcedactions/ForcedWithdrawPage.tsx Outdated Show resolved Hide resolved

packages/frontend/src/view/pages/forcedactions/ForcedWithdrawPage.tsx Outdated Show resolved Hide resolved

packages/frontend/src/view/pages/forcedactions/ForcedWithdrawPage.tsx Outdated Show resolved Hide resolved

packages/frontend/src/view/pages/forcedactions/ForcedTradePage.tsx Outdated Show resolved Hide resolved

packages/frontend/src/view/pages/forcedactions/ForcedTradePage.tsx Outdated Show resolved Hide resolved

packages/frontend/src/view/pages/forcedactions/ForcedTradePage.tsx Outdated Show resolved Hide resolved

packages/frontend/src/view/pages/forcedactions/ForcedWithdrawPage.tsx Outdated Show resolved Hide resolved

packages/frontend/src/view/pages/forcedactions/ForcedWithdrawPage.tsx Outdated Show resolved Hide resolved

packages/frontend/src/view/components/common/OrderedList.tsx Outdated Show resolved Hide resolved

torztomasz added 7 commits

February 17, 2023 13:27


          rename forcedaction to forced-actions

210b9c2


          use <> instead of span

ac37ffd


          prefix positionId with #

83bcde5


          add "Back to assets" button link

d9b9aa9


          use ol + li instead of divs in OrderedList

27a7ff3


          add LinkButton component

10b5b98


          do not use arbitrary px values with max-w

b192eed

sz-piotr approved these changes

View reviewed changes

torztomasz added 2 commits

February 17, 2023 14:30


          add formatHashShort function

3e581fc


          run linter

66578e5

torztomasz force-pushed the implement-new-forced-actions-page branch from 318be0d to 66578e5 Compare

February 17, 2023 13:31


          Merge remote-tracking branch 'origin/master' into implement-new-force…

9296ea4

…d-actions-page

torztomasz merged commit c6bfea2 into master

torztomasz deleted the implement-new-forced-actions-page branch

February 17, 2023 13:42

sz-piotr mentioned this pull request

Project update 2023-02-28 #339

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment