Fix hashing static files for incremental build #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torztomasz
force-pushed
the
fix-hashing-static-files-for-incremental-builds
branch
from
6e4c994
to
76dccdf
Compare
torztomasz
force-pushed
the
fix-hashing-static-files-for-incremental-builds
branch
from
76dccdf
to
69d6c29
Compare
torztomasz
force-pushed
the
fix-hashing-static-files-for-incremental-builds
branch
from
c270aeb
to
7f044df
Compare
sz-piotr
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes the issue where the component with static file dependency would not get the hash updated after the build since the incremental builds were turned on in tsconfig. Unfortunately, hashing takes ~100ms more but it is not a big deal.