Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement search function #338

Merged
merged 12 commits into from Mar 15, 2023
Merged

Implement search function #338

merged 12 commits into from Mar 15, 2023

Conversation

Wendrowiec13
Copy link
Contributor

@Wendrowiec13 Wendrowiec13 commented Mar 8, 2023

Resolves L2B-986

@Wendrowiec13 Wendrowiec13 marked this pull request as ready for review March 8, 2023 11:21
Copy link
Contributor

@torztomasz torztomasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changing the search bar placeholder should also be a part of this PR

@torztomasz torztomasz self-requested a review March 9, 2023 08:33
Copy link
Contributor

@torztomasz torztomasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved by mistake

@Wendrowiec13
Copy link
Contributor Author

I think changing the search bar placeholder should also be a part of this PR

Agreed

@linear
Copy link

linear bot commented Mar 9, 2023

L2B-986 Implement SearchBox functionality

We don't want to have a search results page and searching should go directly to the result or show not-found page.

The placeholder on the search bar should read:

Search by Ethereum address, Stark key, state-update-id or #vault-id

(where vault-id should read position-id if on perpetual).

Users should be able to search for:

  • StarkKey → goes to User Page
  • Ethereum Address → goes to User Page
  • Position/Vault Id → goes to User Page
  • State Update Id → goes to State Update Details
  • State Update hash → goes to State Update Details

Implementation details

Don't use preprocessed_* tables, unless there's no other way - but then discuss with adrian.adamiak

Acceptance Criteria

  • the search is case insensitive

@Wendrowiec13 Wendrowiec13 merged commit 7b4a5a6 into master Mar 15, 2023
@Wendrowiec13 Wendrowiec13 deleted the implement-search branch March 15, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants