New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement search function #338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think changing the search bar placeholder should also be a part of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved by mistake
Agreed |
L2B-986 Implement SearchBox functionality
We don't want to have a search results page and searching should go directly to the result or show not-found page. The placeholder on the search bar should read:
(where vault-id should read position-id if on perpetual). Users should be able to search for:
Implementation detailsDon't use Acceptance Criteria
|
Resolves L2B-986