Don't create link when saying "out of 0" results #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L2B-1055 Fix pagination limit selector width
The width of element is too small, so only the first two digits are shown when a three-digit number is selected. image.png |
Wendrowiec13
approved these changes
Mar 15, 2023
L2B-1113 Fix 0 of 0 pagination
You can click on "You're viewwing 0 of 0" on empty tables (see HomePage and offers table), which leads to a Not Found page. Don't allow 0 to be clickable in this scenario (for any table) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves L2B-1113