Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement offer details page #356

Merged
merged 11 commits into from Mar 28, 2023
Merged

Implement offer details page #356

merged 11 commits into from Mar 28, 2023

Conversation

torztomasz
Copy link
Contributor

Resolves L2B-997

  • implement offer details page
  • implement forced trade offer forms
  • fix linter issues
  • pass offer form props from backend

@linear
Copy link

linear bot commented Mar 21, 2023

L2B-997 Implement all actions for Forced Trade offers

On Forced Trade offer details page (Buy/Sell), there are multiple possible actions, which also depend on the status of the connected (metamask) user (creator/maker or taker):

Possible actions:

  • Cancel (maker)
  • Accept and Sell (taker)
  • Accept and Buy (taker)
  • Cancel - after it was accepted (maker)
  • Send Transaction (maker)
  • Test all these options on Playground or testnet.

All actions above should redirect user to a proper page.

Notes

All those functionalities are implemented in the old explorer, make use of it.

@torztomasz torztomasz marked this pull request as ready for review March 21, 2023 13:14
@torztomasz torztomasz requested a review from adamiak March 24, 2023 08:27
@torztomasz torztomasz added this pull request to the merge queue Mar 28, 2023
@torztomasz torztomasz removed this pull request from the merge queue due to a manual request Mar 28, 2023
@torztomasz torztomasz added this pull request to the merge queue Mar 28, 2023
Merged via the queue into master with commit ae3152a Mar 28, 2023
4 checks passed
@torztomasz torztomasz deleted the implement-offer-details-page branch March 28, 2023 15:54
@sz-piotr sz-piotr mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamiak adamiak adamiak approved these changes

@Wendrowiec13 Wendrowiec13 Awaiting requested review from Wendrowiec13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@torztomasz @adamiak