Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change timestamp to BigInt #369

Merged
merged 2 commits into from Mar 30, 2023
Merged

Change timestamp to BigInt #369

merged 2 commits into from Mar 30, 2023

Conversation

torztomasz
Copy link
Contributor

Resolves L2B-1261

@linear
Copy link

linear bot commented Mar 28, 2023

L2B-1261 Check if Timestamp type is fine to extend Number if it allows initiating from bigint

It seems we cast and potentially lose precision.

@torztomasz torztomasz changed the title Change timestamp to BigInt Add maximum timestamp milliseconds check Mar 29, 2023
@torztomasz torztomasz changed the title Add maximum timestamp milliseconds check Change timestamp to BigInt Mar 30, 2023
@torztomasz torztomasz added this pull request to the merge queue Mar 30, 2023
Merged via the queue into master with commit 0b04fdf Mar 30, 2023
4 checks passed
@torztomasz torztomasz deleted the change-timestamp-to-bigint branch March 30, 2023 06:50
@sz-piotr sz-piotr mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamiak adamiak adamiak approved these changes

@sz-piotr sz-piotr Awaiting requested review from sz-piotr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@torztomasz @adamiak