Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .devcontainer #386

Merged
merged 2 commits into from Apr 17, 2023
Merged

Add .devcontainer #386

merged 2 commits into from Apr 17, 2023

Conversation

adamiak
Copy link
Member

@adamiak adamiak commented Apr 16, 2023

The .devcontainer creates both the Linux system for development, but also sets up a PostgreSQL database.

@adamiak adamiak requested a review from torztomasz April 16, 2023 12:54
volumes:
- postgres-data:/var/lib/postgresql/data
environment:
POSTGRES_PASSWORD: postgres
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should'nt it be "password"?
docker run -d --name=state_explorer_postgres -p 5432:5432 -e POSTGRES_PASSWORD=password postgres That's the command for creating backend database.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's correct - that's the standard setup from VSCode if you build the container with postgres from scratch.

@adamiak adamiak enabled auto-merge April 17, 2023 13:52
@adamiak adamiak added this pull request to the merge queue Apr 17, 2023
Merged via the queue into master with commit 820395e Apr 17, 2023
4 checks passed
@adamiak adamiak deleted the add-devcontainer branch April 17, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants