Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip dataAvailabilityMode in program output #413

Merged
merged 5 commits into from
Jun 20, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/backend/src/Application.ts
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,8 @@ export class Application {
: undefined

const perpetualCairoOutputCollector = new PerpetualCairoOutputCollector(
ethereumClient
ethereumClient,
config.starkex
)
const rollupStateRepository = new MerkleTreeRepository(
database,
Expand Down
3 changes: 2 additions & 1 deletion packages/backend/src/core/PerpetualValidiumSyncService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ export class PerpetualValidiumSyncService implements IDataSyncService {
for (const stateTransition of stateTransitions) {
const [perpetualCairoOutput, batch] = await Promise.all([
this.perpetualCairoOutputCollector.collect(
stateTransition.transactionHash
stateTransition.transactionHash,
stateTransition.blockNumber
),
this.availabilityGatewayClient.getPerpetualBatchData(
stateTransition.batchId
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
import { Hash256 } from '@explorer/types'
import { BigNumber, utils } from 'ethers'

import { StarkexConfig } from '../../config/starkex/StarkexConfig'
import { EthereumClient } from '../../peripherals/ethereum/EthereumClient'
import { toHexData } from '../../utils/toHexData'

Expand All @@ -13,16 +14,31 @@ const ABI = new utils.Interface([
])

export class PerpetualCairoOutputCollector {
constructor(private readonly ethereumClient: EthereumClient) {}
constructor(
private readonly ethereumClient: EthereumClient,
private readonly starkexConfig: StarkexConfig
) {}

async collect(transactionHash: Hash256): Promise<PerpetualCairoOutput> {
async collect(
transactionHash: Hash256,
blockNumber: number
): Promise<PerpetualCairoOutput> {
const tx = await this.ethereumClient.getTransaction(transactionHash)
if (!tx) {
throw new Error('Invalid transaction')
}
const decoded = ABI.decodeFunctionData('updateState', tx.data)
const programOutputValues = decoded.programOutput as BigNumber[]
const hexData = toHexData(programOutputValues)
return decodePerpetualCairoOutput(hexData)

// This is a fix for Apex Goerli testnet, which switches
// to a different program output (one more field) at block 8056029.
// See: https://github.com/starkware-libs/stark-perpetual/blob/eaa284683deec190407fece98b96546d10f6ad67/src/services/perpetual/cairo/output/program_output.cairo#L36
const skipDataAvailabilityModeField =
torztomasz marked this conversation as resolved.
Show resolved Hide resolved
this.starkexConfig.instanceName === 'ApeX' &&
this.starkexConfig.blockchain.chainId === 5 && // it's goerli
blockNumber >= 8056029

return decodePerpetualCairoOutput(hexData, skipDataAvailabilityModeField)
}
}
9 changes: 8 additions & 1 deletion packages/encoding/src/decoding/decodePerpetualCairoOutput.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,16 @@ import { readForcedActions } from './readForcedActions'
import { readModifications } from './readModifications'
import { readState } from './readState'

export function decodePerpetualCairoOutput(data: string): PerpetualCairoOutput {
export function decodePerpetualCairoOutput(
data: string,
skipDataAvailabilityModeField?: boolean
): PerpetualCairoOutput {
const reader = new ByteReader(data)

if (skipDataAvailabilityModeField) {
const _dataAvailabilityMode = reader.readBigInt(32)
torztomasz marked this conversation as resolved.
Show resolved Hide resolved
}

const configurationHash = Hash256(reader.readHex(32))
const assetConfigHashes = readAssetConfigHashes(reader)
const oldState = readState(reader)
Expand Down