Collect from Feeder Gateway in separate transactions (with locking) #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because we want to commit and not lock the table for longer than necessary
torztomasz
approved these changes
Sep 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
L2B-2435 In FeederGatewayCollector, make transactions per state update
…because currently we make one transaction for the whole collection process, which in theory should lock the table for a very long time, (and possibly causes memory leaks somewhere?? maybe not) In short: put lock-tx inside loop, not outside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves L2B-2435
This is because we want to commit and not lock the table for longer than necessary