added upload artifact in workflow #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atul-source
requested review from
jniesz,
sanfern,
jaysheth2,
aka320,
dalalkaran and
binojrajan
as code owners
Signed-off-by: Atul-source <atulprajapati6031@gmail.com> fixing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> fixing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> added name field Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing work flow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> testing workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> test workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> test workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> test workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> test workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> test workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> test workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> test workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com> test workflow Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Atul-source
force-pushed
the
artifact
branch
from
1f01124
to
7574d03
Compare
dthaler
reviewed
Sep 19, 2023
Comment on lines
106
to
107
| copy D:/a/eBPF-Package-Repository/eBPF-Package-Repository/xdp-root/build/xdp_root_kern.o upload_artifact | ||
| copy D:\a\eBPF-Package-Repository\eBPF-Package-Repository\build\xdp-root\Release\xdp_root.exe upload_artifact |
There was a problem hiding this comment.
This paths I got from github actions log
There was a problem hiding this comment.
Should use the same delimiter in both lines.
dthaler
reviewed
Sep 19, 2023
Comment on lines
106
to
107
| copy D:/a/eBPF-Package-Repository/eBPF-Package-Repository/ratelimiting/build/ratelimiting_kern.o upload_artifact | ||
| copy D:\a\eBPF-Package-Repository\eBPF-Package-Repository\build\ratelimiting\Release\ratelimiting.exe upload_artifact |
dthaler
reviewed
Sep 19, 2023
| @@ -92,3 +98,18 @@ jobs: | |||
| run: | | |||
| cmake -B build | |||
| cmake --build build -j $(nproc) --config ${{env.BUILD_CONFIGURATION}} | |||
|
|
|||
| - name: Create artifact directory | |||
| if: matrix.configurations == 'Release' | |||
There was a problem hiding this comment.
Why only for Release? I think artifacts should be uploaded for Debug too, which is what we do in ebpf-for-windows
There was a problem hiding this comment.
Yes for debug case files are created at different path
There was a problem hiding this comment.
Do we need for both cases ?
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
dthaler
approved these changes
Oct 3, 2023
sanfern
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have added upload artifact workflow for each eBPF program. This PR addressed issue #64 .