Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPF CO-RE Changes #83

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

Conversation

Atul-source
Copy link
Contributor

@Atul-source Atul-source commented Mar 27, 2024

In this PR I have made the changes to eBPF Programs to support BPF CO-RE (Compile Once Run Everywhere).
This PR address #28 .
PR for Payload Changes: 110

Copy link

@pmoroney pmoroney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one quick question

@@ -32,6 +32,18 @@ typedef struct flow_record_ {
u16 counter; /* flow_idle_counter */
} flow_record_t;

void *memset(void *b, int c, unsigned long len)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding this? I don't see a reference to it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Function is Present in <string.h> which we are not including hence I have implemented this function, when I am including <string.h> in our bpf Program it is creating lot of compilation issues.

@Atul-source Atul-source marked this pull request as ready for review April 12, 2024 19:35
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
@sanfern
Copy link
Contributor

sanfern commented May 8, 2024

Can we keep connection limit code to work in window env, without BPF-CORE. Need to support both modes

Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
Copy link
Contributor

@sanfern sanfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants