Update dev environments to kernel version 5.15 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sferna1 <santhosh.fernandes@gmail.com>
sanfern
force-pushed
the
sanfern-dev-env-r2
branch
from
ddf226e
to
007e16b
Compare
sanfern
changed the title
jniesz
reviewed
Jul 11, 2023
dev_environment/config.yaml
Outdated
| @@ -7,3 +7,4 @@ configs: | |||
| host_l3af_debug_port: '38899' | |||
| host_l3afd_code_dir: '/code/l3afd' | |||
| traffic_mirroring: 'false' | |||
| host_l3afd_jammy: 'true' | |||
There was a problem hiding this comment.
I would recommend making this generic, so we don't have to change the name of this every release. Maybe call it something like host_distro_version
sanfern
force-pushed
the
sanfern-dev-env-r2
branch
from
e2b0220
to
f2ebf09
Compare
jniesz
approved these changes
Jul 12, 2023
dthaler
reviewed
Jul 18, 2023
dev_environment/Vagrantfile
Outdated
Comment on lines
32
to
34
| l3af.vm.box = "ubuntu/jammy64" | ||
| else | ||
| l3af.vm.provision "shell", inline: <<-SHELL |
There was a problem hiding this comment.
Inconsistent indentation in lines 29 vs 32 vs 34
| # restart after upgrade | ||
| l3af.vm.provision :reload | ||
| end | ||
|
|
There was a problem hiding this comment.
Is this forcing to download 5.15 kernel to /usr/local/bin/ if focal distro detected? Maybe it is good idea to put a comment says, need 5.15 kernel if none jammy distro detected since the ebpf development now require 5.15.0 kernel.
Signed-off-by: sferna1 <santhosh.fernandes@gmail.com>
sanfern
force-pushed
the
sanfern-dev-env-r2
branch
from
f2ebf09
to
e56da23
Compare
dthaler
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades vagrant vm to kernel version v5.15. This is minimum kernel version supported in R2 release.