Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang version #114

Merged
merged 10 commits into from Oct 26, 2022

Conversation

sanfern
Copy link
Contributor

@sanfern sanfern commented Sep 20, 2022

Bump up go version to 1.18.6
Build on ubuntu 20.04
Building static binary

Signed-off-by: Santhosh Fernandes santhosh.fernandes@gmail.com

@sanfern sanfern force-pushed the sanfern-dev-go-version-upgrade branch 10 times, most recently from 5f6eaf6 to ba06256 Compare September 21, 2022 09:24
@sanfern sanfern force-pushed the sanfern-dev-go-version-upgrade branch 5 times, most recently from 0e63205 to 08865af Compare September 21, 2022 10:23
@sanfern sanfern force-pushed the sanfern-dev-go-version-upgrade branch 10 times, most recently from 3bc6e68 to 91c9fca Compare September 21, 2022 18:03
@sanfern sanfern changed the title Bump up go version to 1.18.6 Update golang version Sep 23, 2022
jniesz
jniesz previously approved these changes Sep 23, 2022
Copy link
Contributor

@jniesz jniesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kf/bpfmap.go Outdated Show resolved Hide resolved
jniesz
jniesz previously approved these changes Oct 5, 2022
dthaler
dthaler previously approved these changes Oct 5, 2022
@jniesz jniesz dismissed stale reviews from dthaler and themself via 7da1300 October 5, 2022 16:38
Signed-off-by: sferna1 <santhosh.fernandes@gmail.com>
dthaler
dthaler previously approved these changes Oct 12, 2022
Signed-off-by: sferna1 <santhosh.fernandes@gmail.com>
@sanfern sanfern force-pushed the sanfern-dev-go-version-upgrade branch 2 times, most recently from 39b8525 to c933c53 Compare October 14, 2022 16:26
Signed-off-by: sferna1 <santhosh.fernandes@gmail.com>
@sanfern sanfern force-pushed the sanfern-dev-go-version-upgrade branch from c933c53 to 6da0eab Compare October 14, 2022 16:36
Makefile Outdated Show resolved Hide resolved
Signed-off-by: sferna1 <santhosh.fernandes@gmail.com>
Copy link
Contributor

@jniesz jniesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@charleskbliu0 charleskbliu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sanfern sanfern merged commit e9796a3 into l3af-project:main Oct 26, 2022
@sanfern sanfern deleted the sanfern-dev-go-version-upgrade branch October 26, 2022 09:16
sanfern added a commit to sanfern/l3afd that referenced this pull request Mar 6, 2023
* Update Golang version

Signed-off-by: Santhosh Fernandes <santhosh.fernandes@gmail.com>
Co-authored-by: Jason Niesz <Jason.Niesz@walmart.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants