New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update golang version #114
Merged
sanfern
merged 10 commits into
l3af-project:main
from
sanfern:sanfern-dev-go-version-upgrade
Oct 26, 2022
Merged
Update golang version #114
sanfern
merged 10 commits into
l3af-project:main
from
sanfern:sanfern-dev-go-version-upgrade
Oct 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanfern
requested review from
charleskbliu0,
jniesz and
dthaler
as code owners
September 20, 2022 18:48
sanfern
force-pushed
the
sanfern-dev-go-version-upgrade
branch
10 times, most recently
from
September 21, 2022 09:24
5f6eaf6
to
ba06256
Compare
sanfern
force-pushed
the
sanfern-dev-go-version-upgrade
branch
5 times, most recently
from
September 21, 2022 10:23
0e63205
to
08865af
Compare
sanfern
force-pushed
the
sanfern-dev-go-version-upgrade
branch
10 times, most recently
from
September 21, 2022 18:03
3bc6e68
to
91c9fca
Compare
jniesz
previously approved these changes
Sep 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jniesz
reviewed
Oct 5, 2022
jniesz
previously approved these changes
Oct 5, 2022
dthaler
previously approved these changes
Oct 5, 2022
Signed-off-by: sferna1 <santhosh.fernandes@gmail.com>
dthaler
previously approved these changes
Oct 12, 2022
jniesz
reviewed
Oct 12, 2022
Signed-off-by: sferna1 <santhosh.fernandes@gmail.com>
…anfern/l3afd into sanfern-dev-go-version-upgrade
sanfern
force-pushed
the
sanfern-dev-go-version-upgrade
branch
2 times, most recently
from
October 14, 2022 16:26
39b8525
to
c933c53
Compare
Signed-off-by: sferna1 <santhosh.fernandes@gmail.com>
sanfern
force-pushed
the
sanfern-dev-go-version-upgrade
branch
from
October 14, 2022 16:36
c933c53
to
6da0eab
Compare
jniesz
reviewed
Oct 19, 2022
Signed-off-by: sferna1 <santhosh.fernandes@gmail.com>
jniesz
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
charleskbliu0
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
jaysheth2
approved these changes
Oct 26, 2022
sanfern
added a commit
to sanfern/l3afd
that referenced
this pull request
Mar 6, 2023
* Update Golang version Signed-off-by: Santhosh Fernandes <santhosh.fernandes@gmail.com> Co-authored-by: Jason Niesz <Jason.Niesz@walmart.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump up go version to 1.18.6
Build on ubuntu 20.04
Building static binary
Signed-off-by: Santhosh Fernandes santhosh.fernandes@gmail.com