New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L3AFD metric for ebpf program update command failure count #283
L3AFD metric for ebpf program update command failure count #283
Conversation
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stats/metrics.go
Outdated
prometheus.CounterOpts{ | ||
Namespace: daemonName, | ||
Name: "NFUpdateFailedCount", | ||
Help: "The count of Failed network functions updates", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use the term "network function"
stats/metrics.go
Outdated
Name: "NFUpdateFailedCount", | ||
Help: "The count of Failed network functions updates", | ||
}, | ||
[]string{"host", "ebpf_program", "direction", "interface_name"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why "ebpf_program" instead of "bpf_program"?
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ect#283) * L3AFD metric for ebpf program update command failure count Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
…ect#283) * L3AFD metric for ebpf program update command failure count Signed-off-by: Atul-source <atulprajapati6031@gmail.com> Signed-off-by: sferna1 <santhosh.fernandes@gmail.com>
…ect#283) * L3AFD metric for ebpf program update command failure count Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
A new metric is added to track Update failures of eBPF Function. This PR fixes the issue reported in #282