New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement in error handling #350
Conversation
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the places where we are using the fmt.Errorf()
function we should change it to %w
since that is still valid according to https://pkg.go.dev/fmt@go1.22.1#Errorf. If there are test failures we should investigate that and see if we need to modify the tests to handle wrapped errors.
Signed-off-by: Atul-source <atulprajapati6031@gmail.com>
6d80064
to
0b0b65d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
In this PR I have done error handling improvments.