Increased Websocket frame size from 256 kb to 16 Mb

[elara-leitstellentechnik]

Frame size ist way too small to handle large responses (e.g. lists of peer / device)

[l3nz]

I am dubious about accepting it as it stands as it will allocate a block per request even when you are just expecting a 20-byte payload. Not everybody wants to allocate so much. I would be okay if you made this a user-configurable property, or - better - if there was a way to allocate blocks on demand.
What do you think?

[l3nz]

Actually I'm not sure. It is only used by the Netty HttpObjectAggregator - does it allocate it away in one go, or is it on demand?

[elara-leitstellentechnik]

I will have a look.

But as far as I found out, this is the only way that netty can handle long responses ...

[elara-leitstellentechnik]

I followed the variable all its way into the netty stack: it is only used to make sure that content length does not exceed the given value.

Thus, the given value is not used to allocate memory. The allocation happens somewhere else (where this limit is unknown) can only depend on the content length!

[l3nz]

In this case, I think we can merge safely. Thank you! 😺