Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--dry-run option to show what would happen #119

Open
dkids opened this issue Feb 10, 2020 · 5 comments
Open

--dry-run option to show what would happen #119

dkids opened this issue Feb 10, 2020 · 5 comments

Comments

@dkids
Copy link

dkids commented Feb 10, 2020

I left the house with Traktarr scheduled to run. When I came home, my disk had filled up because of the number of series added. Also, activity.log showed this:

2020-02-09 15:24:53,754 - DEBUG - helpers.radarr - remove_existing_movies - Removing existing movie: 'High School Musical (2006)'
2020-02-09 15:24:53,755 - DEBUG - helpers.radarr - remove_existing_movies - Removing existing movie: 'The Descendants (2011)'
2020-02-09 15:24:53,755 - DEBUG - helpers.radarr - remove_existing_movies - Removing existing movie: 'That Awkward Moment (2014)'
2020-02-09 15:24:53,755 - DEBUG - helpers.radarr - remove_existing_movies - Removing existing movie: 'Colombiana (2011)'
2020-02-09 15:24:53,755 - DEBUG - helpers.radarr - remove_existing_movies - Removing existing movie: 'The Transporter Refueled (2015)'

That was scary but it turned out that the movies hadn't been removed

Programs like rsync have a "--dry-run" option which shows what the result would be if the command was executed. It's not clear to me why Traktarr thought it should remove those movies and I'd like to be able to safely debug.

I wouldn't mind a configuration option for "allow_delete: no" so that it was clear that I don't want Traktarr touching my existing files.

Thanks!

@desimaniac
Copy link
Collaborator

desimaniac commented Feb 10, 2020

It was NOT removing movies from Radarr.. It was getting a list of movies from Radarr and then removing them from the list of movies that came in from Traktarr.

@desimaniac
Copy link
Collaborator

desimaniac commented Feb 10, 2020

Will tweak the log to show that it's removing movies from the Trakt list, not Radarr.

Could also look into a dry-run for the purposes of seeing what would be added or not, etc.

desimaniac added a commit that referenced this issue Feb 10, 2020
Clear up confusion on what and where the movies are being removed from

ref:
- #119
@dkids
Copy link
Author

dkids commented Feb 10, 2020

Thank you!

I'm not sure if you want to put a configuration option for # of lines in the log file. All I had in activity.log were the "removed" entries. So there was a lot of activity but I couldn't see some of what happened, like where series or movies were added.

@desimaniac
Copy link
Collaborator

You have debug enabled. You’ll get more info than you need with that.

@croax
Copy link

croax commented Mar 17, 2021

+1 for having --dry-run available, would be great to see what happends after changing the configuration instead of waiting for the next interval which takes no less than 1 hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants