Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please mark required fields on FormView #39

Closed
max-dev opened this issue Feb 16, 2013 · 4 comments
Closed

Please mark required fields on FormView #39

max-dev opened this issue Feb 16, 2013 · 4 comments
Assignees
@ikostenko
Labels
feature
Milestone
M2 - MVP

Comments

@max-dev
Copy link
Member

max-dev commented Feb 16, 2013

No description provided.

@ghost ghost assigned max-dev Oct 20, 2013
max-dev added a commit that referenced this issue Oct 21, 2013
@max-dev
#88 Please add searching capabilities to combos on FormView
aae0f20 
#39 Please mark required fields on FormView
@ghost ghost assigned ikostenko Oct 21, 2013
@max-dev
Copy link
Member Author

max-dev commented Oct 21, 2013

Done

@max-dev max-dev closed this as completed Oct 21, 2013
@ikostenko
Copy link
Member

Bug found (by automated tests)
If a numeric field is not marked as required, it is not autofilled with 0 on clearing the field value
See the failing tests: http://lightadmin.org/jenkins/job/LightAdmin%20Selenium/org.lightadmin$lightadmin-tests/138/testReport/

@ikostenko ikostenko reopened this Oct 22, 2013
max-dev added a commit that referenced this issue Oct 27, 2013
@max-dev
#39 Please mark required fields on FormView
02c2f7a
@max-dev max-dev closed this as completed Oct 27, 2013
max-dev added a commit that referenced this issue Oct 27, 2013
@max-dev
#39 Please mark required fields on FormView
9112455
max-dev added a commit that referenced this issue Oct 27, 2013
@max-dev
#39 Please mark required fields on FormView
6968927
@ikostenko
Copy link
Member

A field with @Column(nullable=false) is marked as reqiured, but is not validated

@ikostenko ikostenko reopened this Oct 30, 2013
@max-dev
Copy link
Member Author

max-dev commented Nov 1, 2013

LightAdmin validation is based on JSR-303 Bean Validation spec.
You should annotate your fields with one of @ NotNull, @ NotBlank or @notempty annotations.

@max-dev max-dev closed this as completed Nov 1, 2013
max-dev added a commit that referenced this issue Nov 1, 2013
@max-dev
#39 Please mark required fields on FormView
11617ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikostenko ikostenko

Labels
feature
Projects
None yet
Milestone
M2 - MVP
Development

No branches or pull requests
2 participants
@max-dev @ikostenko