Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libpredict #23

Merged
merged 115 commits into from
Feb 13, 2016
Merged

Libpredict #23

merged 115 commits into from
Feb 13, 2016

Conversation

bjorgan
Copy link
Member

@bjorgan bjorgan commented Dec 28, 2015

Orbit calculations have been replaced with calls to libpredict (latest development version) (issue #4). All unused code and most global variables have been removed, in addition to removing the server functionality (issue #3). I have also tried to clean up wherever possible (mostly Predict(), SingleTrack() and MultiTrack()), and keep the functionality and layout originally in place (and make some minor improvements here and there). It has been tested against the dummy drivers of rotctl and rigctl.

Some sacrifices have been made:

  • Lunar pass predictions miss properties: RA, Dec, GHA, Vel, Range (displays 0. Should it rather be removed altogether?). I propose to add this back after Missing properties in moon/sun calculation libpredict#49 has been dealt with, create new issue after merge.
  • Solar pass predictions miss properties: RA, Dec, GHA. See above.
  • Lon/Lat convention is hard-coded to N/E, while original version lets the user decide. I propose to add it back after resolving issue Settings variables -> struct #21, create new issue after merge.

@bjorgan
Removed UDP server functionality.
d174e20
@bjorgan
Removed PredictAt().
9fdc160
@bjorgan
Removed pthreads from CMakeLists.txt
1ec6fd7
@bjorgan
Removed unused variables.
92a14fa
@bjorgan
Removed PreCalc() and Calc().
67e1ea6
@bjorgan
Removed AOS/LOS functions (first point where Calc() is called, alread…
ceb5620 
…y now it's present in libpredict.)
@bjorgan
Predict() changes in progress.
6948090
@bjorgan
Added libpredict functions in Predict().
c540c32
@bjorgan
Added phase and orbit number to the Predict() screen.
6704cf6
@bjorgan
Removed xterm variable.
1cfc257
@bjorgan
Some variable naming cleanup and commenting in Predict().
826a282
@bjorgan
Moved string lengths to constant in Predict().
f4db4ca
@bjorgan
Fixed data field alignment in Predict().
ce5c337
@bjorgan
Comment about visible passes in Predict().
4777820
@bjorgan
Some libpredict insertion in SingleTrack.
a8c035a
@bjorgan
Shuffled around the satellite info display lines in SingleTrack. Put …
a97d0ee 
…the satellite db entry into the function arguments.
@bjorgan
Degrees for moon/sun aziele.
dfc1192
@bjorgan
Fixes for AOS/LOS displaying in SingleTrack, shuffled around the rota…
9201189 
…tion information placement in the code.
@bjorgan
Fix after recent changes to libpredict.
0da58e1
@bjorgan
Removed use of global qth variable in MultiTrack, take array of orbit…
1798cda 
…s as input.
@bjorgan
Initial cleanup of multitrack, everything broken.
f295991
@bjorgan
Made MultiTrack modifications compile.
08f52ea
@bjorgan
AOS/LOS calc and some formatting in MultiTrack.
7e9cd6a
@bjorgan
Memory cleanup of created arrays.
5f9ddb7
@bjorgan
Sun and moon tracking using libpredict in MultiTrack.
d6da627
@bjorgan
Fix in observer creation and AOS indexing.
0883a6b
@bjorgan
Minor layout adjustments.
bc3009e
@bjorgan
libpredict into Illumination().
05cb9cb
@bjorgan
Wrote new function for encompassing both sun and moon pass predictions.
5110416
@bjorgan
Using common sunmoon-predict instead of PredictMoon.
278f3e1
@bjorgan
Terminate the Select() menu list in order to avoid memory violations,…
96c7d0a 
… fix some initialization issues.
@bjorgan
Initialize observation struct in sun/moon prediction.
7865350
@bjorgan
Remove memory leak in Select().
afcd6b2
@bjorgan
Set catnum in the TLE database, so that satdb entries are set correctly.
2a836e7
@bjorgan
Merge branch 'master' into libpredict
e9b2654
@bjorgan
Re-enabled satellite switching in SingleTrack mode. Calculate squint …
b5fa3e3 
…angle only when squint flag is set, removed daynum change throughout property displaying, resetting all variables at the beginning of orbit displaying in order to remove some AOS/LOS displaying errors when switching satellite, moved transponder name displaying so that there is no delay when switching satellites.
@bjorgan
View name in single track mode.
310ee69
@bjorgan
Stop at each end of the satellite array when switching through them i…
8425592 
…n singletrack.
@bjorgan
Added back unit change in multitrack.
f48fa0e
@bjorgan
Fix in uplink/downlink shift.
072e77c
@bjorgan
Removed last traces of io_lat/io_lon (can add back later), removed ca…
ab9e089 
…lc_squint global flag.
@bjorgan
Fix fix in shift.
6c7205d
@bjorgan
QTH config file compatibility against original predict.
d10d895
@bjorgan
Remove unused variables.
571b859
@bjorgan
Remove netport variable.
e191f70
@bjorgan
Remove global array 'val'.
f33ed69
@bjorgan
Avoid printed double zeroes after one pass in Predict().
57a0fd8
@bjorgan
Remove superfluous space.
4e977d0
@bjorgan
Fix API breakage in newest development version of libpredict.
c2b0589
@bjorgan
Fix in satellite name displaying in GetStartTime.
6bd5427
@bjorgan
Fix satellite name and number in Predict, PredictVisible and Illumina…
70198de 
…tion screens.
@bjorgan
Merge branch 'master' into libpredict
1a77e33
@bjorgan
Remove warning from predict_parse_tle.
d8da31f
@bjorgan
Correction in name displaying in SingleTrack.
bc48639
@bjorgan
Rename orbitals -> orbital_elements_array.
e79af6f
@bjorgan bjorgan mentioned this pull request Jan 3, 2016
Merged
ryeng added a commit that referenced this pull request Feb 13, 2016
@ryeng
Merge pull request #23 from la1k/libpredict
a330e0c 
Libpredict
@ryeng ryeng merged commit a330e0c into master Feb 13, 2016
@bjorgan bjorgan deleted the libpredict branch February 13, 2016 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjorgan @ryeng