fix: add more NaN type guards

la55u · Dec 5, 2020 · 7664d1a · 7664d1a
1 parent 2402b5a
commit 7664d1a
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/src/BottomSheet.tsx b/src/BottomSheet.tsx
@@ -142,17 +142,17 @@ export const BottomSheet = React.forwardRef<
     maxHeightRef,
     maxSnapRef,
     minSnapRef,
-    updateSnap,
     observeBoundsRef,
+    updateSnap,
   } = useSnapResponder({
     draggingRef,
-    maxHeight,
-    minSnap,
-    prefersReducedMotion,
-    maxSnap,
     findSnap,
     heightRef,
     lastSnapRef,
+    maxHeight,
+    maxSnap,
+    minSnap,
+    prefersReducedMotion,
     set,
   })
   useImperativeHandle(
@@ -485,6 +485,13 @@ export const BottomSheet = React.forwardRef<
     axis: 'y',
   })
 
+  if (Number.isNaN(maxSnapRef.current)) {
+    throw new TypeError('maxSnapRef is NaN!!')
+  }
+  if (Number.isNaN(minSnapRef.current)) {
+    throw new TypeError('minSnapRef is NaN!!')
+  }
+
   // @TODO the ts-ignore comments are because the `extrapolate` param isn't in the TS defs for some reason
   const interpolateBorderRadius =
     maxHeightRef.current !== maxSnapRef.current