Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lzhuf: port to Go #41

Closed
martinhpedersen opened this issue Jul 19, 2016 · 0 comments
Closed

lzhuf: port to Go #41

martinhpedersen opened this issue Jul 19, 2016 · 0 comments
Assignees
@martinhpedersen
Milestone
v1.0.0

Comments

@martinhpedersen
Copy link
Member

The current implementation of lzhuf is a cgo wrapper around lzhuf.c from jnos2.

Porting the code to Go would eliminate the need for cgo, thus making the wl2k-go framework even more portable. It will also allow us to further improve the code, getting rid of the intermediate temp files and other rough edges.

I've already added some more tests that will help us ensure that we don't break compatibility with other Winlink software.
@martinhpedersen martinhpedersen added this to the v1.0.0 milestone Jul 19, 2016
@martinhpedersen martinhpedersen self-assigned this Jul 19, 2016
martinhpedersen added a commit that referenced this issue Jul 20, 2016
@martinhpedersen
lzhuf: Return error from NewReader functions
fe91210 
This is needed by the new Go port (issue #41)
martinhpedersen added a commit that referenced this issue Jul 20, 2016
@martinhpedersen
fbb: Adopt the recent lzhuf API change
af158b6 
Issue #41
martinhpedersen added a commit that referenced this issue Jul 20, 2016
@martinhpedersen
lzhuf: More tests
894cbd0 
Issue #41
martinhpedersen added a commit that referenced this issue Jul 20, 2016
@martinhpedersen
lzhuf: Ported to pure Go
cfe8d1c 
Closes #41
@martinhpedersen martinhpedersen mentioned this issue Jul 20, 2016
Merged
martinhpedersen added a commit that referenced this issue Jul 22, 2016
@martinhpedersen
lzhuf: Ported to pure Go
60aabf5 
Closes #41
martinhpedersen added a commit that referenced this issue Jul 22, 2016
@martinhpedersen
lzhuf: Add new testfile with binary data
66689b5 
Tried sending this winlink message to a CMS using the Go port
of lzhuf. CMS was unable to decompress it, but decoded it
successfully when compressed with the original C version.

Issue #41
martinhpedersen added a commit that referenced this issue Jul 27, 2016
@martinhpedersen
lzhuf: Fix unintentional differences from C version
73983ff 
After reviewing the code I found two minor differences from the
original C version. Fixing this caused the latest test to pass.

Issue #41
@martinhpedersen martinhpedersen mentioned this issue Aug 2, 2016
Closed
martinhpedersen added a commit that referenced this issue Aug 3, 2016
@martinhpedersen
lzhuf: Minor documentation changes
e094666 
Issue #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinhpedersen martinhpedersen

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@martinhpedersen