Python-side selection #316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the status on this? Should we close & reopen later when someone has time to implement it? |
ceriottm
force-pushed
the
python_selection
branch
from
970514b
to
ae0ef52
Compare
|
well, it's actually kind of working. there are some problems handling multiple viewers and the synchronization with the map. I think it however might be good to keep this on hold until we have done something about #326, as I think one underlying issue is that the settings synchronization mechanism is not well documented and so there's a lot of guesswork. |
|
Sure, I'm just trying to clear PR no-one is working on. Should I close this PR and keep the branch around? |
|
I'd leave it on if you don't mind. I think it might take half an hour if we look at it together. |
|
We'll re-open this whenever we have time for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traitlet-based synchronization of the selected structure. Facilitates interaction with other ipywidgets.
We should also use this to Fix #244 for good.