Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPHERICART_OPENMP and SPHERICART_ENABLE_CUDA are ignored when the compiler does not support them #104

Open
Luthaf opened this issue Jan 24, 2024 · 0 comments

Comments

@Luthaf
Copy link
Contributor

Luthaf commented Jan 24, 2024

If a user tries to build sphericart with either of these option set to ON, and cmake can not find the requirements, we will just print a message Could not find a CUDA compiler or Could not find OpenMP, and continue building the code as if these options where disabled.

I see how this is the most sensible when building the code from setup.py, where we want to enable these if possible but still build in the other case, but it might create issues for C++ users who think they built everything right but then get slowdown/crash later at runtime.

At the very least, both should be a warning when enabled but not found (currently only OpenMP is); and I would appreciate if we can turn these into errors without breaking the python build. Maybe we could have a IMPLICIT_DISABLE_IS_ERROR option, ON by default and set to OFF by setup.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant