Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add support for secret provider for webhook #20

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

PeterSurda
Copy link
Contributor

Webhook secret can how use buildbot's secret management interface.

e.g.

c['www']['change_hook_dialects'] = {
    'gitea': {
        'secret': util.Secret('my_gitea_webhook_secret'),
        'class': GiteaHandler,
        'onlyIncludePushCommit': True,
    }
|

Used GitHub buildbot plugin as a reference.

@PeterSurda
Copy link
Contributor Author

any feedback?

@pampersrocker
Copy link
Contributor

Sorry, I'm quite busy at the moment. You can verify it by running the trial Unit tests against it and if you feel comfortable create a unit test with an active secret as well.

@PeterSurda
Copy link
Contributor Author

Don't know how to run the tests. travis-ci gets stuck in a loop and times out: https://travis-ci.org/github/PeterSurda/buildbot-gitea . The code works on my system.

@pampersrocker pampersrocker merged commit 3e59f20 into lab132:master Apr 26, 2021
@pampersrocker
Copy link
Contributor

Thank you for the contribution! I've added unit tests for a secret provider. This will be part of the next minor release, but I want another feature done first before making another release.

I know the travis-ci gets stuck in some dependency setup but was not able to figure out how to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants