Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not generating tax rate id in all cases, implement testing replac… #42

Merged
merged 1 commit into from Mar 18, 2019

Conversation

davidweterings
Copy link
Member

Fix not generating tax rate id in all cases, implement testing replaceTaxRate action

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #42 into master will decrease coverage by <.01%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   74.79%   74.79%   -0.01%     
==========================================
  Files         138      138              
  Lines       21892    21905      +13     
==========================================
+ Hits        16375    16383       +8     
- Misses       5517     5522       +5
Impacted Files Coverage Δ
src/commercetools/testing/utils.py 63.41% <33.33%> (-1.59%) ⬇️
src/commercetools/testing/tax_categories.py 83.33% <72.72%> (-3.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1fa9b9...c7cb834. Read the comment docs.

@mvantellingen mvantellingen merged commit 33a111e into master Mar 18, 2019
@mvantellingen mvantellingen deleted the bugfix/fix-tax-rate-ids branch March 18, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants