Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new resource commercetools_tax_category #38

Merged
merged 1 commit into from Nov 6, 2018

Conversation

tleguijt
Copy link
Contributor

@tleguijt tleguijt commented Nov 5, 2018

No description provided.

@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #38 into master will decrease coverage by 0.37%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage    31.4%   31.02%   -0.38%     
==========================================
  Files           9       10       +1     
  Lines        1777     2050     +273     
==========================================
+ Hits          558      636      +78     
- Misses       1209     1404     +195     
  Partials       10       10
Impacted Files Coverage Δ
commercetools/provider.go 75.6% <100%> (+0.3%) ⬆️
commercetools/resource_tax_category.go 28.3% <28.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80c5ef7...eee6aad. Read the comment docs.

Copy link
Member

@davidweterings davidweterings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question; do you know what the policy is on testing for this repo?

commercetools/resource_tax_category.go Outdated Show resolved Hide resolved
commercetools/resource_tax_category.go Outdated Show resolved Hide resolved
commercetools/resource_tax_category.go Outdated Show resolved Hide resolved
@davidweterings davidweterings merged commit 92fe9bb into master Nov 6, 2018
@mvantellingen mvantellingen deleted the feature/tax_category branch March 17, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants