New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new resource commercetools_tax_category #38

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
2 participants
@tleguijt
Contributor

tleguijt commented Nov 5, 2018

No description provided.

@codecov

This comment has been minimized.

codecov bot commented Nov 5, 2018

Codecov Report

Merging #38 into master will decrease coverage by 0.37%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage    31.4%   31.02%   -0.38%     
==========================================
  Files           9       10       +1     
  Lines        1777     2050     +273     
==========================================
+ Hits          558      636      +78     
- Misses       1209     1404     +195     
  Partials       10       10
Impacted Files Coverage Δ
commercetools/provider.go 75.6% <100%> (+0.3%) ⬆️
commercetools/resource_tax_category.go 28.3% <28.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80c5ef7...eee6aad. Read the comment docs.

@davidweterings

General question; do you know what the policy is on testing for this repo?

Show resolved Hide resolved commercetools/resource_tax_category.go Outdated
Show resolved Hide resolved commercetools/resource_tax_category.go Outdated
Show resolved Hide resolved commercetools/resource_tax_category.go Outdated

@davidweterings davidweterings merged commit 92fe9bb into master Nov 6, 2018

2 of 4 checks passed

codecov/patch 28.57% of diff hit (target 31.4%)
Details
codecov/project 31.02% (-0.38%) compared to 80c5ef7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment