Wagtail 4.0 - 5.1 #227
Merged
Wagtail 4.0 - 5.1 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add support for Django 4.2 and Wagtail 5.0
Upgrade wagtail 50
Wagtail attempts to load SVG sprites from this url and injects them into the browsers DOM. When this url is guarded by 2FA, the HTML of the 2FA verification page is injected into the DOM instead. This results in a duplicate form on the page.
|
I tried this branch today as part of an upgrade to wagtail 5, and I am always getting a duplicate devices screen. By that I mean I get the QR code form twice, it seems to be that some javascript is injecting it at the bottom of the dom, since it is not there when I view the source. This also means that I am unable to create a new otp. Are you seeing anything like this? |
Allow 'wagtailadmin_sprite' url to bypass 2FA
|
@ArnarTumi Yes i'm getting the same issue. |
nickmoreton
force-pushed
the
support/wagtail-51
branch
from
695027b
to
724d524
Compare
nickmoreton
force-pushed
the
support/wagtail-51
branch
from
724d524
to
ef46a17
Compare
Closed
|
@davisnando @ArnarTumi Can you try this now, it works for me locally using the sandbox. Thanks |
|
@nickmoreton Seems to work now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wagtail 5.1 release notes