Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move gateway module to plex package #653

Merged

Conversation

thetechnocrat-dev
Copy link
Contributor

@thetechnocrat-dev thetechnocrat-dev commented Sep 13, 2023

Goal

  • Make local development easier by not requiring having to release a new plex bin to test changes in gateway

Changes

1 Moved /frontend up one directory level to project root
2 Made gateway a plex package instead of separate module
3 Added web command to plex, which starts the go web app
4 Moved docker-compose.yml up one directory level to project root
5 Moved gateway/Readme.md instructions to Development section of project root Readme.md

Commands to run app now (all from project root)

docker compose up -d
npm --prefix ./frontend install
npm --prefix ./frontend run dev
go run main.go web # (or go build then ./plex web)

@linear
Copy link

linear bot commented Sep 13, 2023

@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Sep 15, 2023 2:11pm

@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci September 14, 2023 14:54 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci September 14, 2023 15:02 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci September 14, 2023 15:04 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci September 15, 2023 14:11 — with GitHub Actions Inactive
Copy link
Contributor

@acashmoney acashmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐰 🎩 🌟

@thetechnocrat-dev thetechnocrat-dev merged commit dceca82 into main Sep 15, 2023
3 checks passed
@thetechnocrat-dev thetechnocrat-dev deleted the 650-lab-609-part1-fix-plex-into-gateway-imports branch September 15, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants