Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upload datafile view bug #663

Merged

Conversation

thetechnocrat-dev
Copy link
Contributor

Changes

  1. Datafile add view no longer shows an error message if the request succeeds, instead it redirects to data list view
  2. Removed isVisible and isPublic since those didn't actually have any functionality
  3. Changed some server fmt.Println to log.Println which should make it easier to plug the production server into log recording software

https://www.loom.com/share/b63c6e42a7114d6bb21197e21698b482

@thetechnocrat-dev thetechnocrat-dev linked an issue Sep 22, 2023 that may be closed by this pull request
@linear
Copy link

linear bot commented Sep 22, 2023

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2023 5:19am

Copy link
Contributor

@acashmoney acashmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upload works smoothly with redirect to datafiles page 😎

🚀 🏁

@acashmoney acashmoney temporarily deployed to ci September 26, 2023 05:19 — with GitHub Actions Inactive
@acashmoney acashmoney merged commit acd9686 into main Sep 26, 2023
3 checks passed
@acashmoney acashmoney deleted the 662-lab-622-make-sure-datafile-upload-view-works-smoothly branch September 26, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LAB-622] make sure datafile upload view works smoothly
2 participants