Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LAB-679] trying to fix compute in docker issue with CI #703

Merged
merged 35 commits into from
Oct 19, 2023

Conversation

alabdao
Copy link
Collaborator

@alabdao alabdao commented Oct 16, 2023

No description provided.

@linear
Copy link

linear bot commented Oct 16, 2023

LAB-679 Fix compute in docker issue in CI

If we mount the /root/ directly inside compute we can potentially get around this issue in CI.

@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 19, 2023 6:39pm

@alabdao alabdao temporarily deployed to ci October 16, 2023 14:18 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:18 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:18 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:18 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:18 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:21 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:33 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:33 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:34 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:34 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:34 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:38 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:58 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:58 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:58 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:58 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 14:58 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 16, 2023 15:01 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 19, 2023 13:44 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 19, 2023 13:44 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 19, 2023 13:44 — with GitHub Actions Inactive
@alabdao
Copy link
Collaborator Author

alabdao commented Oct 19, 2023

Currently private part fails cuz of code changes.
This is ready to be merged.

@alabdao alabdao temporarily deployed to ci October 19, 2023 15:45 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 19, 2023 15:45 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 19, 2023 15:45 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 19, 2023 15:49 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 19, 2023 16:06 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 19, 2023 16:06 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 19, 2023 16:06 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 19, 2023 16:10 — with GitHub Actions Inactive
Copy link
Contributor

@thetechnocrat-dev thetechnocrat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this suppose to point to local host?

Screenshot 2023-10-19 at 2 23 54 PM

@@ -168,8 +171,10 @@ services:
condition: service_healthy

ipfs:
image: "ipfs/kubo"
image: "ipfs/kubo:v0.18.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

name: docker-compose-plugin-${{matrix.os}}
path: ./docker-compose
# # Only downloading cli for macos
# ci-setup-compose:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is the CI using docker compose now that this commented out?

Also, why did you comment out this code instead of just removing it?

Copy link
Collaborator Author

@alabdao alabdao Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is the CI using docker compose now that this commented out?

ubuntu nodes already have docker compose I was mistaken installing it when it wasn't needed. So removed it as it was redundant.

Also, why did you comment out this code instead of just removing it?

I'm thinking in the future there maybe testing on macos-13, if I can get it to work. So I left it in commented out for macos-13 future testing as its not needed for linux host.

Copy link
Contributor

@thetechnocrat-dev thetechnocrat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge so you are not blocked, but had some questions above.

@alabdao
Copy link
Collaborator Author

alabdao commented Oct 19, 2023

Is this suppose to point to local host?
Screenshot 2023-10-19 at 2 23 54 PM

That's meant to print which BACALHAU_API_HOST is pointing to just as additional debug setup/

@alabdao alabdao temporarily deployed to ci October 19, 2023 18:39 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 19, 2023 18:39 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 19, 2023 18:39 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 19, 2023 18:43 — with GitHub Actions Inactive
@alabdao alabdao merged commit dd63838 into main Oct 19, 2023
9 of 10 checks passed
@alabdao alabdao deleted the ops/LAB-679-fix-compute-in-docker branch October 19, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants