-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LAB-679] trying to fix compute in docker issue with CI #703
Conversation
LAB-679 Fix compute in docker issue in CI
If we mount the /root/ directly inside compute we can potentially get around this issue in CI. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Currently private part fails cuz of code changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -168,8 +171,10 @@ services: | |||
condition: service_healthy | |||
|
|||
ipfs: | |||
image: "ipfs/kubo" | |||
image: "ipfs/kubo:v0.18.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
name: docker-compose-plugin-${{matrix.os}} | ||
path: ./docker-compose | ||
# # Only downloading cli for macos | ||
# ci-setup-compose: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is the CI using docker compose now that this commented out?
Also, why did you comment out this code instead of just removing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is the CI using docker compose now that this commented out?
ubuntu
nodes already have docker compose
I was mistaken installing it when it wasn't needed. So removed it as it was redundant.
Also, why did you comment out this code instead of just removing it?
I'm thinking in the future there maybe testing on macos-13
, if I can get it to work. So I left it in commented out for macos-13
future testing as its not needed for linux host.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge so you are not blocked, but had some questions above.
No description provided.