Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove maxTime limit since --max-job-execution-timeout is now configurable #728

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

alabdao
Copy link
Collaborator

@alabdao alabdao commented Oct 25, 2023

What type of PR is this? (check all applicable)

  • 🎮 Feature
  • 🐛 Bug Fix
  • 🍧 Refactor
  • 🔋 Optimization
  • 📓 Documentation Update

Description

For running long jobs, we need this limit removed as timeout is now configurable in Bacalhau.

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2023 8:45pm

@alabdao alabdao temporarily deployed to ci October 25, 2023 14:14 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 25, 2023 14:14 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 25, 2023 14:14 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 25, 2023 14:18 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 25, 2023 14:18 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 25, 2023 17:12 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 25, 2023 17:12 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 25, 2023 17:12 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 25, 2023 17:16 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 25, 2023 17:16 — with GitHub Actions Inactive
Copy link
Contributor

@thetechnocrat-dev thetechnocrat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alabdao alabdao temporarily deployed to ci October 25, 2023 20:45 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 25, 2023 20:46 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 25, 2023 20:46 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 25, 2023 20:50 — with GitHub Actions Inactive
@alabdao alabdao temporarily deployed to ci October 25, 2023 20:50 — with GitHub Actions Inactive
@alabdao alabdao merged commit 81599db into main Oct 25, 2023
8 checks passed
@alabdao alabdao deleted the remove-max-time-60-limit branch October 25, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants