Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add announcements in the app and website top bars #787

Merged
merged 4 commits into from
Feb 8, 2022

Conversation

bbenoist
Copy link
Contributor

@bbenoist bbenoist commented Jan 13, 2022

Work performed

I've made sure that AnnounceKit is used in both the website an in the app.
See #635 for details

Results

Users should be informed about our new features, discounts, downtimes and maintenance operations

Problems encountered

See my progress reports in #635

Caveats

Can't be used without an AnnounceKit account.

Resolved issues

Closes #635

Newly raised issues

No

@vercel
Copy link

vercel bot commented Jan 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/labelflow/labelflow/XAdyyoHUsbqPghUXvtvtocTXtH1q
✅ Preview: https://labelflow-git-feature-announcements-labelflow.vercel.app

@bbenoist bbenoist marked this pull request as ready for review February 3, 2022 13:19
@bbenoist
Copy link
Contributor Author

bbenoist commented Feb 7, 2022

@nicOwlas Code is OK to be merged. Just let me know once you've finished our first announcement (of type warning 😉 ) and I'll deploy the PR on production.

@nicOwlas
Copy link
Member

nicOwlas commented Feb 7, 2022

@nicOwlas Code is OK to be merged. Just let me know once you've finished our first announcement (of type warning 😉 ) and I'll deploy the PR on production.

The announcement is done. If you want to review it, it's here: https://announcekit.app/dashboard/post
If it's good, then go for merge!

Since AnnounceKit filters doesn't seems to work yet:
announcekitapp/announcekit-react#28
@bbenoist
Copy link
Contributor Author

bbenoist commented Feb 7, 2022

@nicOwlas I've reviewed the post: I'd add a warning-sign emoji (⚠️) in the title but it's not a blocking point so I'll merge the PR once the CI is OK. Other than that, it looks good to me 👍

@Jordanlelay I've just removed the announcement code from /website (since the filter problem described in announcekitapp/announcekit-react#28 is not yet fixed). I've made a single commit with the changes if you want to review them quickly: 96069fb

@Jordanlelay
Copy link
Contributor

@Jordanlelay I've just removed the announcement code from /website (since the filter problem described in announcekitapp/announcekit-react#28 is not yet fixed). I've made a single commit with the changes if you want to review them quickly: 96069fb

Good to go !

@bbenoist bbenoist merged commit 94ee122 into main Feb 8, 2022
@bbenoist bbenoist deleted the feature/announcements branch February 8, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inform end-users about new features, important changes and maintenance
3 participants