Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os.path.normpath filenames to display paths correctly on Windows #1362

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

michaelitvin
Copy link

No description provided.

@wkentaro
Copy link
Member

wkentaro commented Dec 2, 2023

@michaelitvin Thank you for the PR. If you don't mind, can you sharing the before/after screenshots (actually I don't own windows machines)

@wkentaro wkentaro added os: windows Windows-specific problem (@wkentaro cannot help) fix pr labels Dec 2, 2023
@wkentaro wkentaro self-assigned this Dec 2, 2023
@nxlitvin
Copy link

nxlitvin commented Dec 9, 2023

Before (this is official v5.4.0a0 on Windows 11):
image

This is the effect of this PR:

>>> print(os.path.normpath(r"C:/Users/vboxuser/Downloads\cat.jpg"))
C:\Users\vboxuser\Downloads\cat.jpg

@wkentaro
Copy link
Member

@nxlitvin Thanks!

@wkentaro wkentaro merged commit ec88ffe into labelmeai:main Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr os: windows Windows-specific problem (@wkentaro cannot help)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants