Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect warning "Warning: matrix is not full rank" #8

Open
Nanne opened this issue Oct 10, 2018 · 0 comments
Open

Incorrect warning "Warning: matrix is not full rank" #8

Nanne opened this issue Oct 10, 2018 · 0 comments

Comments

@Nanne
Copy link

Nanne commented Oct 10, 2018

In steer2HarmMtx.py numpy.rank() is used to get the matrix rank. However, this function is deprecated and replaced by the .ndim attribute, because numpy.rank() did not return the matrix rank, but the number of dimensions.

Instead the numpy.linalg.matrix_rank() should be used to obtain the matrix rank.

The same also goes for the use of numpy.rank() in pyPyrUtils.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant