Merge pull request #1170 from Bastian-Krause/bst/atomic-replace-unbound

util/atomic: fix UnboundLocalError in atomic_replace()
labgrid-project · May 17, 2023 · 0dd63f9 · 0dd63f9
2 parents 2f00b39 + 7e0a144
commit 0dd63f9
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/labgrid/util/atomic.py b/labgrid/util/atomic.py
@@ -2,6 +2,7 @@
 import tempfile
 
 def atomic_replace(filename, data):
+    f = None
     try:
         with tempfile.NamedTemporaryFile(
                 mode='wb',
@@ -12,7 +13,8 @@ def atomic_replace(filename, data):
             os.fsync(f.fileno())
         os.replace(f.name, filename)
     finally:
-        try:
-            os.unlink(f.name)
-        except FileNotFoundError:
-            pass
+        if f is not None:
+            try:
+                os.unlink(f.name)
+            except FileNotFoundError:
+                pass