Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ubootdriver: _await_prompt is missing an interrupt character #117

Closed
wdmegrv opened this issue Aug 7, 2017 · 0 comments
Closed

ubootdriver: _await_prompt is missing an interrupt character #117

wdmegrv opened this issue Aug 7, 2017 · 0 comments

Comments

@wdmegrv
Copy link

wdmegrv commented Aug 7, 2017

https://github.com/labgrid-project/labgrid/blob/master/labgrid/driver/ubootdriver.py#L171

There should be a self.console.write() call before _check_prompt(). Otherwise u-boot will be not interrupted properly in it's boot sequence.
Emantor referenced this issue in Emantor/labgrid Oct 20, 2017
@Emantor
ubootdriver: configurable interrupt and correct autoboot
834d60a 
The UBootDriver did not correctly interrupt the autoboot, resulting in it
swallowing one character for the next command. Interrupt the autoboot and while
at it also make it configurable like the BareboxDriver

Fixes #117

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
@Emantor Emantor mentioned this issue Oct 20, 2017
Merged
Emantor referenced this issue in Emantor/labgrid Oct 20, 2017
@Emantor
ubootdriver: configurable interrupt and correct autoboot
77e2e9d 
The UBootDriver did not correctly interrupt the autoboot, resulting in it
swallowing one character of the next command. Interrupt the autoboot and while
at it also make it configurable like the BareboxDriver.

Fixes #117

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Emantor referenced this issue in Emantor/labgrid Oct 20, 2017
@Emantor
ubootdriver: configurable interrupt and correct autoboot
4041c9e 
The UBootDriver did not correctly interrupt the autoboot, resulting in it
swallowing one character of the next command. Interrupt the autoboot and while
at it also make it configurable like the BareboxDriver.

Fixes #117

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Emantor referenced this issue in Emantor/labgrid Oct 20, 2017
@Emantor
ubootdriver: configurable interrupt and correct autoboot
05240cc 
The UBootDriver did not correctly interrupt the autoboot, resulting in it
swallowing one character of the next command. Interrupt the autoboot and while
at it also make it configurable like the BareboxDriver.

Fixes #117

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
jluebbe pushed a commit that referenced this issue Oct 20, 2017
@Emantor @jluebbe
ubootdriver: configurable interrupt and correct autoboot
0d1ff87 
The UBootDriver did not correctly interrupt the autoboot, resulting in it
swallowing one character of the next command. Interrupt the autoboot and while
at it also make it configurable like the BareboxDriver.

Fixes #117

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wdmegrv