qemudriver: export get_qemu_base_args method #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1212 +/- ##
========================================
- Coverage 62.9% 62.9% -0.1%
========================================
Files 159 159
Lines 11737 11746 +9
========================================
+ Hits 7388 7393 +5
- Misses 4349 4353 +4
☔ View full report in Codecov by Sentry. |
a3f
force-pushed
the
afa/run-qemu-interactive
branch
from
280a1be
to
e1fb3b6
Compare
a3f
changed the title
This introduces no functional change, but makes it easier to split the
function into two in a follow-up commit:
- one function to just compute the base command line
- one function to actually store the command line into the object
along with QMP-specific options
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Next commit will factor command line computation out of on_activate to make it available for use with an interactively started Qemu. Prepare for this by collecting everything that is not applicable to non-QMP usage at the end of the function. No functional change intended. Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
For debugging, it can be useful to start an interactive session for the user to access the DUT console. This is possible with real targets through labgrid-client -s STATE console, but no equivalent exists yet for targets using QEMUDriver. Resolving that may be a bigger undertaking, so for now, let's provide a class method get_qemu_base_args, that returns the list of arguments sans QMP parts. Users can then initialize labgrid as usual and call the function to get the command line and start Qemu for interactive use without having to duplicate the labgrid environment parsing as in [1]. [1]: https://github.com/barebox/barebox/blob/v2023.05.0/test/emulate.pl#L226 Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Emantor
reviewed
Jun 19, 2023
|
barebox test/emulate.pl duplicates the YAML parsing to be able to run Qemu interactively. This PR is preparation for using existing labgrid infrastructure for that. See here for how it's used: https://lore.barebox.org/barebox/20230619095240.4168216-4-a.fatoum@pengutronix.de/T/#m6e6deb363efc855b0ec77d46d8f2ba6c0f67ff21 My first PR attempt just started QEMU directly. I am open to implement it either way. |
|
Is this ok? Should I split this PR up, so the non-functional changes can be merged first and I can submti PRs for other Qemu related things? |
a3f
force-pushed
the
afa/run-qemu-interactive
branch
from
e1fb3b6
to
318e778
Compare
Emantor
approved these changes
Aug 1, 2023
Emantor
added
the
Ready for review
Emantor
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For debugging, it can be useful to start an interactive session for the
user to access the DUT console. This is possible with real targets
through labgrid-client -s STATE console, but no equivalent exists yet
for targets using QEMUDriver. Resolving that may be a bigger
undertaking, so for now, let's provide a class method
get_qemu_base_args, that returns the list of arguments sans QMP parts.
Users can then initialize labgrid as usual and call the function to
get the command line and start Qemu for interactive use without having
to duplicate the labgrid environment parsing as in 1.
- what do you use the feature for? Start Qemu interactively with same environment yaml used for testing
- how does labgrid benefit as a testing library from the feature? makes debugging failing tests easier
- how did you verify the feature works? I verified tests work and that calling the function starts a usable qemu
Checklist
THis is rebased on #1211 to avoid a conflict.