driver/sigrok: add blocking capture methods, misc improvements to sigrok driver #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please split out the fixes to separate commits, or even better a separate PR. |
apparently some versions of sigrok-cli on some distros (for example Ubuntu 22.04) default to false, resulting in invalid parsing Signed-off-by: Felix Zwettler <felix.zwettler@duagon.com>
…urce is remote Signed-off-by: Felix Zwettler <felix.zwettler@duagon.com>
when specified filename is not absolute and using a remote sigrok resource. Usually when an absolute path is supplied as `filename` the call `abs.path.join()` resolves to `filename`. But when the file path is relative, it resolves it to a relative path appended to the tmp dir, instead of from where the user calls this method. Signed-off-by: Felix Zwettler <felix.zwettler@duagon.com>
|
ok, done |
flxzt
changed the title
flxzt
force-pushed
the
sigrok-driver-improv
branch
from
fc6411b
to
1f26099
Compare
flxzt
changed the title
flxzt
force-pushed
the
sigrok-driver-improv
branch
3 times, most recently
from
3718d95
to
76a0b1e
Compare
|
It looks like the documentation requires additional fixes. |
Emantor
added
the
needs author info
flxzt
force-pushed
the
sigrok-driver-improv
branch
from
f1c31da
to
b4ac548
Compare
|
I think it should be all fixed now. Sorry about the force pushes, I kept forgetting to sign-off |
The driver expected that the sigrok-cli is successful and starts capturing in continuous mode. When the call is unsuccessful, the driver then waited for the creation of the capture file forever. Fixed by checking if the sigrok-cli process terminated prematurely while waiting for the existence of the capture file. Signed-off-by: Felix Zwettler <Felix.Zwettler@duagon.com>
…otely the signal that is supposed to terminate the process SIGINT was not being propagated through ssh. The driver waited for termination forever. fixed by quitting sigrok-cli through an emulated keypress by sending a char over ssh. Signed-off-by: Felix Zwettler <Felix.Zwettler@duagon.com>
…ver impl This adds blocking capture methods where capture time or number of samples are specified in advance. Some of the internals are refactored to allow for code re-use and API documentation is added to clarify the usage of the sigrok driver. Signed-off-by: Felix Zwettler <felix.zwettler@duagon.com>
flxzt
force-pushed
the
sigrok-driver-improv
branch
from
56bad4a
to
31ebd5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds blocking capture methods where capture time or number of
samples are specified in advance.
Some of the internals are refactored to allow for code re-use
and API documentation is added to clarify the usage of the sigrok driver.
Checklist
Also:
thanks for writing and maintaining labgrid as a open-source project, it's pretty awesome!
depends on #1346