Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements updates from pyup #189

Merged
merged 5 commits into from
Feb 15, 2018

Conversation

Emantor
Copy link
Member

@Emantor Emantor commented Feb 9, 2018

I squashed the pyup pull request and added my own fixes. Afterwards we can enable pyup for labgrid.

@Emantor Emantor self-assigned this Feb 9, 2018
@Emantor Emantor requested a review from jluebbe February 9, 2018 14:53
@Emantor
Copy link
Member Author

Emantor commented Feb 9, 2018

Ah, how do we solve the DCO checks? Is there a workaround for a bot feature like this?

@Emantor Emantor force-pushed the topic/pyup_support branch 2 times, most recently from 9fe97a0 to ecff5c3 Compare February 12, 2018 11:07
@codecov-io
Copy link

codecov-io commented Feb 12, 2018

Codecov Report

Merging #189 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #189   +/-   ##
======================================
  Coverage    51.1%   51.1%           
======================================
  Files          89      89           
  Lines        5002    5002           
======================================
  Hits         2558    2558           
  Misses       2444    2444
Impacted Files Coverage Δ
labgrid/resource/udev.py 41% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc5b9a...83f201b. Read the comment docs.

@Emantor
Copy link
Member Author

Emantor commented Feb 12, 2018

According to dcoapp/app#21 there is an issue for DCO and bot support, but nobody started work on it yet.

Copy link
Member

@jluebbe jluebbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we handle the extra_require dependencies, with the requirements.txt? Add separate <extra>-requirements.txt files and document them?

pyModbusTCP==0.1.5
pysnmp==4.4.4
pysnmp-mibs==0.1.6
pytest==3.4.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest is already part of requirements.txt.

requests
autobahn
xmodem>=0.4.5
PyYAML==3.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyYAML is needed by default.

@Emantor
Copy link
Member Author

Emantor commented Feb 15, 2018

Updated.

@Emantor
Copy link
Member Author

Emantor commented Feb 15, 2018

I split out the optional features and documented them in the installation section as well.

jluebbe
jluebbe previously approved these changes Feb 15, 2018
Pin pyyaml to latest version 3.12
Pin attrs to latest version 17.4.0
Update crossbar from 17.8.1.post1 to 17.12.1
Pin pexpect to latest version 4.3.1
Pin pymodbustcp to latest version 0.1.5
Pin pysnmp to latest version 4.4.4
Pin pysnmp-mibs to latest version 0.1.6
Pin pytest to latest version 3.4.0
Pin pytest-cache to latest version 1.0
Pin pytest-cov to latest version 2.5.1
Pin pytest-isort to latest version 0.1.0
Pin pytest-mock to latest version 1.6.3
Pin pytest-pylint to latest version 0.7.1
Pin pytest-runner to latest version 3.0
Pin pyudev to latest version 0.21.0
Pin yapf to latest version 0.20.1
Pin requests to latest version 2.18.4
Pin autobahn to latest version 17.10.1
Pin sphinxcontrib-napoleon to latest version 0.6.1
Pin sphinx to latest version 1.6.7
Pin sphinx_rtd_theme to latest version 0.2.4
Update docutils from 0.13.1 to 0.14

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Attrs 17.4.0 contains a breaking change which fixes the super class load order.
These are the appropriate changes for labgrid, not backwards compatible with
older releases.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
The requirements.txt file is used for the new installation process,
crossbar-requirements is used to fix the crossbar dependencies as well.
To use labgrid as an application, we pin the requirements of labgrid to known
tested values.
We also remove crossbar from extra_require, since we have a new installation
process for the coordinator.
We also split out requirements files for every optional feature.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Document the new installation process for labgrid as an application and update
the coordinator installation section as well.
Optional requirements get an extra section too.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
@jluebbe jluebbe merged commit 0d0d7fc into labgrid-project:master Feb 15, 2018
@Emantor Emantor deleted the topic/pyup_support branch February 18, 2018 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants