Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSHFS: Add helper class to mount filesystem on target through ssh #251

Closed
wants to merge 1 commit into from
Closed

SSHFS: Add helper class to mount filesystem on target through ssh #251

wants to merge 1 commit into from

Conversation

nefethael
Copy link
Contributor

Signed-off-by: Vincent Prince vincent.prince.fr@gmail.com

Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
@codecov-io
Copy link

codecov-io commented May 28, 2018

Codecov Report

Merging #251 into master will decrease coverage by <.1%.
The diff coverage is 47.8%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #251     +/-   ##
========================================
- Coverage      55%   54.9%   -0.1%     
========================================
  Files         105     106      +1     
  Lines        6243    6288     +45     
========================================
+ Hits         3437    3458     +21     
- Misses       2806    2830     +24
Impacted Files Coverage Δ
labgrid/driver/sshdriver.py 48.4% <100%> (ø) ⬆️
labgrid/external/__init__.py 100% <100%> (ø) ⬆️
labgrid/external/sshfs.py 45.4% <45.4%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cfe025...1487d93. Read the comment docs.

@kjeldflarup
Copy link
Contributor

Would be nice with an example in the examples section.

A use case could be to combine it with mktemp -d on the DUT, and mount a tmpdir fixture from pytest.

See also https://github.com/labgrid-project/labgrid/issues/250

@nefethael
Copy link
Contributor Author

@kjeldflarup you're right, i'll add example some day but here how i use it:

in test.py:
sshfs = SSHFS(cmd.target, 'mydir', '/tmp/mymount')

in local.yaml:

....
    - NetworkService:
        address: myhost.local
        username: john
        password: doe
        name: 'mydir'
....
images:
  mydir: '/home/john/doe/mywanteddir'

Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code addtitions look fine, however documentation and an example are missing. Please add those.

@jluebbe
Copy link
Member

jluebbe commented May 15, 2019

This should go into https://github.com/labgrid-project/labgridhelper.

@jluebbe jluebbe closed this May 15, 2019
@jluebbe jluebbe added the helper feature which fits into labgridhelper label May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helper feature which fits into labgridhelper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants