linting: declare methods without self-use static and annotate legitimate methods #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
======================================
Coverage 54.8% 54.8%
======================================
Files 106 106
Lines 6264 6264
======================================
Hits 3438 3438
Misses 2826 2826
Continue to review full report at Codecov.
|
jluebbe
requested changes
Jul 2, 2018
labgrid/remote/client.py
Outdated
| @@ -925,7 +925,7 @@ def create(): | |||
|
|
|||
| def find_role_by_place(config, place): | |||
| for role, role_config in config.items(): | |||
| resources, _ = target_factory.normalize_config(role_config) | |||
| resources, _ = target_factory.__class__.normalize_config(role_config) | |||
There was a problem hiding this comment.
The class should be unnecessary here. You can use staticmethods on instances as well.
tests/test_factory.py
Outdated
| @@ -54,7 +54,7 @@ def test_convert_dict(self): | |||
| BarPort: | |||
| name: bar | |||
| """) | |||
| l = target_factory._convert_to_named_list(data) | |||
| l = target_factory.__class__._convert_to_named_list(data) | |||
There was a problem hiding this comment.
This shouldn't be necessary here as well.
No "self" is used, so declare it static. Signed-off-by: Bastian Stender <bst@pengutronix.de>
No "self" is used so declare it static. Signed-off-by: Bastian Stender <bst@pengutronix.de>
No "self" is used so declare it static. Signed-off-by: Bastian Stender <bst@pengutronix.de>
…t() static No "self" is used so declare it static. Avoid importing TargetFactory and thereby legitimizing its use instead of using the global TargetFactory instance "target_factory". Signed-off-by: Bastian Stender <bst@pengutronix.de>
No "self" use is valid here as it is inherited by IMXUSBLoader. "self" is used there. Signed-off-by: Bastian Stender <bst@pengutronix.de>
No "self" is used so declare it static. Avoid importing TargetFactory and thereby legitimizing its use instead of using the global TargetFactory instance "target_factory". Signed-off-by: Bastian Stender <bst@pengutronix.de>
These methods are inherited by USBSerialPortExport. "self" is used there. Signed-off-by: Bastian Stender <bst@pengutronix.de>
Bastian-Krause
force-pushed
the
bst/no-self-use
branch
from
2cf5992
to
884358c
Compare
|
Pushed changes:
|
jluebbe
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this linting warning: