Python3.10 #21
Python3.10 #21
Conversation
… validator validator. Updated validation code to support validation of the .json file.
|
Sorry if this is to big of a pull request. |
There was a problem hiding this comment.
Unfortunately, it might be a while until we approve this request. Most of the changes look good, but ljsimpleregisterlookup is still on Python 2.7. If this request were approved, we would not be able to pull new changes from ljm_constants to ljsimpleregisterlookup without it breaking or doing some workaround, so we do not want to approve this request until ljsimpleregisterlookup is upgraded. A test deployment failed when I tried to upgrade ljsimpleregisterlookup to Python 3, and getting that working is a low priority at the moment.
…ssages. Add .github validation
|
Not ideal, but reverted back to Python2; heroku docs? |
There was a problem hiding this comment.
Everything except the two os module imports I commented on look good to me.
About upgrading to Python 3:
I did upgrades in the backend for Python3, bumped the runtime to Python 3.10.4, and bumped some of the dependencies up to the newest release versions. The updated LJSimpleRegisterLookup works locally, but fails when trying to deploy. It appears to be a CORS header error, so there must be a configuration missing somewhere.
* Delete travis.yml * Add MS github validation code. * Addressed .json file issues. Updated LabJackMModbusMap.h. Updated the validator validator. Updated validation code to support validation of the .json file. * Added validation to save changes. * Updates to *.h file for changes. * Addressed comparison test TODO (ljmmm_test.py). * Add build badge. * Update README.md * Indented validator code. * Edited readme to reflect the use of github CI. * Add validation checks for all included .json files. Improved error messages. Add .github validation * Change name of validation step. * Call path based operators through os to simplify imports.
Python3.10