Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LoadBalancing metrics #60

Merged
merged 3 commits into from
Apr 12, 2022

Conversation

axilleastr
Copy link
Contributor

@axilleastr axilleastr commented Apr 11, 2022

resolves: #51

Description

This PR enables support for CloudFlare LoadBalancer metrics.
Introduces the following changes:

  •   feat: Export LoadBalancer analytics metrics
    

    This commit enables support for exporting LoadBalancer analytics
    metrics. LoadBalancer's pool health is reported:

    • 1 -> healthy
    • 0 -> unhealthy

    as long as the number of requests each pool receives from each CFL
    network location[1]

  1. https://developers.cloudflare.com/load-balancing/reference/load-balancing-analytics/#graphql-analytics
  • feat: Export browser map page views count
    

    Export browser_map_page_views_count requests metric

Test plan

All changes have been tested locally with a local monitoring stack pulling metrics.

  • LoadBalancers pool health:
    Screenshot 2022-04-11 at 2 32 00 PM

  • Browser map page views per family
    Screenshot 2022-04-11 at 2 37 49 PM

This commit enables support for exporting LoadBalancer analytics
metrics. LoadBalancer's pool health is reported:
* 1 -> health
* 0 -> unhealthy
as long as the number of requests each pool receives from each CFL
network location[1]

1. https://developers.cloudflare.com/load-balancing/reference/load-balancing-analytics/#graphql-analytics
Export browser_map_page_views_count requests metric
@axilleastr axilleastr changed the title Add LoadBalancing metrics Add support for LoadBalancing metrics Apr 11, 2022
@axilleastr
Copy link
Contributor Author

@martinhaus for some reason I can't add reviewers, I would appreciate a review when you have some time :)
Thanks in advance!

@martinhaus
Copy link
Member

LGTM

thank you for the contribution @axilleastr !

@martinhaus martinhaus self-requested a review April 12, 2022 17:33
@martinhaus martinhaus merged commit 8e97133 into lablabs:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Add Load Balancing Metrics
2 participants