fix: Explicitly handle null values in some output formatters (#183)

lablup · Nov 6, 2021 · 1aa6fde · 1aa6fde
1 parent d916636
commit 1aa6fde
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/changes/183.fix b/changes/183.fix
@@ -0,0 +1 @@
+Fix handling of null values in some output formatters, which caused regression of `backend.ai info` command
diff --git a/src/ai/backend/client/output/formatters.py b/src/ai/backend/client/output/formatters.py
@@ -85,6 +85,8 @@ def format_console(self, value: Any, field: FieldSpec) -> str:
         return str(value)
 
     def format_json(self, value: Any, field: FieldSpec) -> Any:
+        if value is None:
+            return None
         if isinstance(value, decimal.Decimal):
             return str(value)
         elif isinstance(value, dict):
@@ -97,10 +99,14 @@ def format_json(self, value: Any, field: FieldSpec) -> Any:
 class NestedDictOutputFormatter(OutputFormatter):
 
     def format_console(self, value: Any, field: FieldSpec) -> str:
+        if value is None:
+            return "(null)"
         value = json.loads(value)
         return format_nested_dicts(value)
 
     def format_json(self, value: Any, field: FieldSpec) -> Any:
+        if value is None:
+            return None
         return json.loads(value)