Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

Add support for dotfiles of domains and groups #132

Merged
merged 3 commits into from Sep 21, 2020

Conversation

yongkyunlee
Copy link
Contributor

Added client support for operations for domain and group dotfiles

Solving issue lablup/backend.ai#210

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #132 into master will decrease coverage by 0.23%.
The diff coverage is 21.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   41.42%   41.18%   -0.24%     
==========================================
  Files          67       67              
  Lines        6289     6352      +63     
==========================================
+ Hits         2605     2616      +11     
- Misses       3684     3736      +52     
Impacted Files Coverage Δ
src/ai/backend/client/func/dotfile.py 18.81% <4.41%> (-19.97%) ⬇️
src/ai/backend/client/cli/dotfile.py 38.88% <80.00%> (+6.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39157c2...97e39c3. Read the comment docs.

Copy link
Member

@adrysn adrysn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR looks good. However, it seems like that domain-level dotfiles are not mounted to the session container. Please refer following image. There are domain-level dotfiles, .a and .Renviron, but when I launched a session, I was unable to locate them. For group-/keypair-level dotfiles, I found no problem. (FYI, ./run.sh is a wrapper of backend.ai, so you can just think it as backend.ai)

image

@yongkyunlee
Copy link
Contributor Author

yongkyunlee commented Sep 18, 2020

I think this PR looks good. However, it seems like that domain-level dotfiles are not mounted to the session container. Please refer following image. There are domain-level dotfiles, .a and .Renviron, but when I launched a session, I was unable to locate them. For group-/keypair-level dotfiles, I found no problem. (FYI, ./run.sh is a wrapper of backend.ai, so you can just think it as backend.ai)

There was an error in the manager, so I fixed this issue here.

@adrysn
Copy link
Member

adrysn commented Sep 21, 2020

LGTM.

@yongkyunlee yongkyunlee merged commit 9e771a3 into master Sep 21, 2020
@yongkyunlee yongkyunlee deleted the feature/add-support-shell-profiles branch September 21, 2020 02:04
@achimnol achimnol added this to the 20.09 milestone Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants