Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

Rich formatting draft #174

Merged
merged 9 commits into from Aug 31, 2021
Merged

Rich formatting draft #174

merged 9 commits into from Aug 31, 2021

Conversation

nokchalatte
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ achimnol
✅ nokchalatte
❌ Chrysan Angela Piarso


Chrysan Angela Piarso seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Chrysan Angela Piarso and others added 4 commits August 13, 2021 10:58
* Make most of them to set the minimum version, so that other
  components that rely on the client SDK could specify more flexible
  version ranges.
@nokchalatte nokchalatte marked this pull request as ready for review August 20, 2021 02:26
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #174 (010c8aa) into main (c86d588) will not change coverage.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   42.06%   42.06%           
=======================================
  Files          68       68           
  Lines        6652     6652           
=======================================
  Hits         2798     2798           
  Misses       3854     3854           
Impacted Files Coverage Δ
src/ai/backend/client/cli/announcement.py 28.57% <20.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c86d588...010c8aa. Read the comment docs.

Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change please.

src/ai/backend/client/cli/announcement.py Outdated Show resolved Hide resolved
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to replace the news fragment!

@achimnol achimnol merged commit 32e53e2 into lablup:main Aug 31, 2021
@achimnol achimnol added this to the 21.09 milestone Aug 31, 2021
achimnol pushed a commit that referenced this pull request Aug 31, 2021
* Use Rich to pretty-format the announcements in CLI
youngjun0627 pushed a commit to youngjun0627/backend.ai-client-py that referenced this pull request Sep 12, 2021
* Use Rich to pretty-format the announcements in CLI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants