Update mypy to 0.930 #105
Merged
Update mypy to 0.930 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* While pyright (VSCode) supports ParamSpec and Concatenate, mypy 0.930 does not support Concatenate yet. Temporarily comment related lines with "type: ignore". * Introduce a wrapper function to ensure immutable usage of ChainMap which is defined as mutable in typeshed, with minimal runtime overheads.
Codecov Report
@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 75.94% 75.85% -0.10%
==========================================
Files 23 23
Lines 3201 3193 -8
==========================================
- Hits 2431 2422 -9
- Misses 770 771 +1
Continue to review full report at Codecov.
|
achimnol
force-pushed
the
fix/update-mypy-0.930
branch
from
db7359c
to
43d8306
Compare
achimnol
force-pushed
the
fix/update-mypy-0.930
branch
from
43d8306
to
66b5aeb
Compare
achimnol
added a commit
that referenced
this pull request
Dec 27, 2021
* setup: Update mypy to 0.930
* fix: Modernize common.etcd coding style and fix type errors
- While pyright (VSCode) supports ParamSpec and Concatenate,
mypy 0.930 does not support Concatenate yet.
Temporarily comment related lines with "type: ignore".
- Introduce a wrapper function to ensure immutable usage of
ChainMap which is defined as mutable in typeshed, with minimal
runtime overheads.
* test: Let test_utils type-checked and workaround python/mypy#11850
Backported-From: main (22.03)
Backported-To: 21.09
achimnol
added a commit
that referenced
this pull request
Dec 27, 2021
* setup: Update mypy to 0.930
* fix: Modernize common.etcd coding style and fix type errors
- While pyright (VSCode) supports ParamSpec and Concatenate,
mypy 0.930 does not support Concatenate yet.
Temporarily comment related lines with "type: ignore".
- Introduce a wrapper function to ensure immutable usage of
ChainMap which is defined as mutable in typeshed, with minimal
runtime overheads.
* test: Let test_utils type-checked and workaround python/mypy#11850
Backported-From: main (22.03)
Backported-To: 21.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates mypy to 0.930.