Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared plugin configs for multi-group plugins #40

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Jul 2, 2020

This PR makes it possible to use "config/plugins/_/<entrypoint-name>" as the place for shared
configs for multi-group plugins (e.g., plugins that have both hook and webapp plugins).

  • Read and merge configs from the shared location and group-sepcific location
  • Unify the watcher to monitor the prefix changes and dispatch the changes to plugins

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a86c9f7) 75.24% compared to head (34f2c15) 75.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   75.24%   75.24%           
=======================================
  Files          17       17           
  Lines        2375     2375           
=======================================
  Hits         1787     1787           
  Misses        588      588           
Impacted Files Coverage Δ
src/ai/backend/common/plugin/__init__.py 90.69% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@achimnol achimnol marked this pull request as draft August 27, 2020 08:22
Base automatically changed from master to main February 24, 2021 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant